Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Reveal in File Explorer" to tab bar context menu #12073

Closed
msujew opened this issue Jan 16, 2023 Discussed in #12072 · 4 comments · Fixed by #12076
Closed

Add "Reveal in File Explorer" to tab bar context menu #12073

msujew opened this issue Jan 16, 2023 Discussed in #12072 · 4 comments · Fixed by #12076
Labels
navigator issues related to the navigator/explorer proposal feature proposals (potential future features)

Comments

@msujew
Copy link
Member

msujew commented Jan 16, 2023

Discussed in #12072

Originally posted by ouliuquan January 16, 2023
For now Theia don't have Reveal in File Explorer, Theia's Reveal in Explorer only locate file in resouce manager.
I think this real functional, can we consider adding this feature?

open_in_explorer

@msujew msujew added navigator issues related to the navigator/explorer proposal feature proposals (potential future features) labels Jan 16, 2023
@vince-fugnitto
Copy link
Member

I believe the command already exists for electron (#10523), not sure what it would look like in the browser:

export const OPEN_CONTAINING_FOLDER = Command.toDefaultLocalizedCommand({
id: 'revealFileInOS',
category: CommonCommands.FILE_CATEGORY,
label: isWindows ? 'Reveal in File Explorer' :
isOSX ? 'Reveal in Finder' :
/* linux */ 'Open Containing Folder'
});

@msujew
Copy link
Member Author

msujew commented Jan 16, 2023

@ouliuquan Do you run Theia in Electron or browser mode? I agree with Vince here, I believe it might not be possible to implement this feature in browser mode. VSCode also only has it when running locally in Electron.

@ouliuquan
Copy link

@vince-fugnitto Yes, I use the offical Eclipse Theia Blueprint, and my own build yarn electron package, this function(show file in file explorer) didn't show in Tabs, but show in Project Manager field.

My OS: Windows 11

@msujew msujew changed the title Can we add the "Reveal in File Explorer" features? Add "Reveal in File Explorer" to tab bar context menu Jan 16, 2023
@ouliuquan
Copy link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer proposal feature proposals (potential future features)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants