Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench.editor.highlightModifiedTabs has not effect #12185

Closed
kittaakos opened this issue Feb 15, 2023 · 0 comments · Fixed by #12367
Closed

workbench.editor.highlightModifiedTabs has not effect #12185

kittaakos opened this issue Feb 15, 2023 · 0 comments · Fixed by #12367
Labels
ui/ux issues related to user interface / user experience

Comments

@kittaakos
Copy link
Contributor

Bug Description:

Setting workbench.editor.highlightModifiedTabs to true does not do anything. The logic still exists in Theia, but the styles have been removed. Breaking change: #10908

Steps to Reproduce:

  1. Open Theia (browser or electron), set auto-save to off and workbench.editor.highlightModifiedTabs to true,
  2. Touch a file. You can see the dirty modifier, but the extra top border is missing from the dirty tab. It works from VS Code.

Electron:

highlightModifiedTabs_01.mp4

Browser:

highlightModifiedTabs_02.mp4

VS Code:

highlightModifiedTabs_03.mp4

Additional Information

  • Operating System: macOS
  • Theia Version: 6f53691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editor: restore highlightModifiedTabs functionality FernandoAscencio/theia
2 participants
@kittaakos @msujew