Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to install plugins from the command line #13406

Closed
tsmaeder opened this issue Feb 21, 2024 · 2 comments · Fixed by #13421
Closed

Add command to install plugins from the command line #13406

tsmaeder opened this issue Feb 21, 2024 · 2 comments · Fixed by #13421
Assignees
@tsmaeder
Labels
plug-in system issues related to the plug-in system theia-cli issues related to the theia-cli
Milestone
1.47.0

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

VS Code has a command to install plugins from the command line like so:

code --install-extension (<extension-id> | <extension-vsix-path>)

We should add a command to the Theia command line to do the same.
@tsmaeder tsmaeder self-assigned this Feb 21, 2024
@tsmaeder tsmaeder added plug-in system issues related to the plug-in system theia-cli issues related to the theia-cli labels Feb 21, 2024
@msujew
Copy link
Member

msujew commented Feb 21, 2024

See PR that implements installing plugins via their IDs: #13369

@tsmaeder
Copy link
Contributor Author

Implementing this functionality the same way as in VS Code encounters a bunch of problems:

  1. We cannot tell which plugins are present in the system until the plugins deployment has run as a side-effect of system startup. So doing the "this plugin is already installed" message is not possible before deployment is running
  2. Determining the set of plugins in the system and uninstalling is done via "HostedPluginSupport", which is a service that runs in the plugin host and which is not available in the back end, only the front-end. Implementing a cli command in the front-end is not possible, because in the browser case, there may not be a front-end for a long time.

What we can do is install the given version (or the latest version if none is given) unconditionally. I have sketched a change proposal that would allow to handle plugin management more robustly here

tsmaeder added a commit to tsmaeder/theia that referenced this issue Feb 26, 2024
@tsmaeder
Introduce '--install-plugin' cli command. Fixes eclipse-theia#13406
3e77c28 
Inspired by the VS Code --install-extension command. Users can give the
option multiple times with either a plugin id of the form
"publisher.name[@Version]" or with a file path designating a *.vsix
file.

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this issue Feb 26, 2024
Merged
1 task
tsmaeder added a commit that referenced this issue Feb 28, 2024
@tsmaeder
Introduce '--install-plugin' cli command. (#13421)
627dad4 
Fixes #13406

Inspired by the VS Code --install-extension command. Users can give the
option multiple times with either a plugin id of the form
"publisher.name[@Version]" or with a file path designating a *.vsix
file.

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
plug-in system issues related to the plug-in system theia-cli issues related to the theia-cli
Projects
None yet
Milestone
1.47.0
Development

Successfully merging a pull request may close this issue.

Introduce '--install-plugin' cli command. tsmaeder/theia
3 participants
@msujew @jfaltermeier @tsmaeder