Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect undo/redo action on notebook editors #13962

Closed
msujew opened this issue Jul 25, 2024 · 0 comments · Fixed by #13963
Closed

Incorrect undo/redo action on notebook editors #13962

msujew opened this issue Jul 25, 2024 · 0 comments · Fixed by #13963
Labels
bug bugs found in the application notebook issues related to notebooks
Milestone

Comments

@msujew
Copy link
Member

msujew commented Jul 25, 2024

Bug Description:

Our logic to capture undo/redo is pretty outdated and doesn't work correctly in a lot of cases. One of the examples is listed in the reproduction steps.

Steps to Reproduce:

  1. Open a normal text document and change something to make it dirty
  2. Open a notebook editor and add a new cell
  3. Defocus the notebook editor cell and run the undo action. It will undo the changes in the text document instead of removing the new cell.

Additional Information

  • Theia Version: 1.52
@msujew msujew added bug bugs found in the application notebook issues related to notebooks labels Jul 25, 2024
@jfaltermeier jfaltermeier added this to the 1.53.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application notebook issues related to notebooks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants