Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main toolbar commands in notebook no longer working #14178

Closed
msujew opened this issue Sep 16, 2024 · 0 comments · Fixed by #14179
Closed

Main toolbar commands in notebook no longer working #14178

msujew opened this issue Sep 16, 2024 · 0 comments · Fixed by #14179
Labels
bug bugs found in the application notebook issues related to notebooks
Milestone
1.54.0

Comments

@msujew
Copy link
Member

msujew commented Sep 16, 2024 •
edited
Loading

Bug Description:

After #13982, the main toolbar contributions no longer seem to work. I've tracked this down to incorrect selection of the current html context element, as the tabIndex property on the notebook editor element is no longer being set.

Steps to Reproduce:

  1. Install the Jupyter plugin and open a notebook
  2. Attempt to use any of the jupyter contributed toolbar items (like Restart Kernel)
  3. Nothing happens and an error will be printed to the console.

image

Additional Information

  • Operating System: Windows
  • Theia Version: 1.53.0
@msujew msujew added bug bugs found in the application notebook issues related to notebooks labels Sep 16, 2024
@msujew msujew mentioned this issue Sep 16, 2024
Merged
1 task
@sgraband sgraband added this to the 1.54.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application notebook issues related to notebooks
Projects
None yet
Milestone
1.54.0
Development

Successfully merging a pull request may close this issue.

Fix notebook context selection eclipse-theia/theia
2 participants
@msujew @sgraband