Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia AI: Workspace Agent - allow overriding its methods + rebinding #14433

Closed
safisa opened this issue Nov 11, 2024 · 5 comments
Closed

Theia AI: Workspace Agent - allow overriding its methods + rebinding #14433

safisa opened this issue Nov 11, 2024 · 5 comments

Comments

@safisa
Copy link
Contributor

safisa commented Nov 11, 2024

Feature Description:

Hi,

  1. first can you change the signature of the workspace agent to be protected instead of private - especially the 'exclude' method.
  2. second, how can I rebind the GetWorkspaceFileList? or a tool? since I want to change the exclude logic!

Thanks

@JonasHelming
Copy link
Contributor

:-)
See #14426

@JonasHelming
Copy link
Contributor

In a nutshell, we are extracting the exclude logic to a rebindyble service and also plan to introduce a setting to

  1. Respect .gitignore
  2. Allow configurable exclusions

@JonasHelming
Copy link
Contributor

This is merged: #14426
can you check whether it fixes this issue for you?

@safisa
Copy link
Contributor Author

safisa commented Nov 12, 2024

This is merged: #14426 can you check whether it fixes this issue for you?

I will check it once it is released (in 1.56), from the code I see that this should resolve my issue.
Thanks a lot, this was just on time :)

@JonasHelming
Copy link
Contributor

I will close this, please reopen if the problem presists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants