Bracket Pair Colorizer 2

[dsseng]

Description

Bracket Pair Colorizer 2 (v0.0.9) extension doesn't activate and work.

Reproduction Steps

1. Download Bracket Pair Colorizer 2 v0.0.9 from VS Marketplace as a VSIX file.
2. Unpack it into a newly created folder in ~/.theia/extensions or prebuilt plugins folder
3. Start Theia

OS and Theia version:
OS: Ubuntu 19.10
Theia: master

Diagnostics:
When I open Theia I get this error message:

Activating extension Bracket Pair Colorizer 2 failed: Cannot find module '/path/to/theia-repo/packages/plugin-ext/lib/plugin/node/node_modules.asar/vscode-textmate'.

In console, 2 of these messages are printed (console.warn):

``` root WARN ../../packages/monaco/lib/browser/textmate/textmate-registry.js/

[vince-fugnitto]

@sh7dm for your own information, one cannot use the VS Code Marketplace directly outside of official Microsoft products as it violates their terms of use (and is subsequently illegal). We have created open-vsx for that exact purpose, and if your extension is not provided, you can submit a request to include it (https://github.com/open-vsx/publish-extensions).

I suspect something may be missing during packaging and it is the reason vscode-textmate complains.

[dsseng]

I know, I used the manually-download VSIX, that should work. Do you think the issue is on extension side?

[vince-fugnitto]

I know, I used the manually-download VSIX, that should work. Do you think the issue is on extension side?

I'm checking out their repo and attempting to build it myself.
I do see it is still a beta, and their last publish was a while ago.

[vince-fugnitto]

This method looks a bit fishy, the fact that it requires it but does not provide it itself makes me think that it is included in vscode by default (especially since it looks at the appRoot):

private getNodeModule(moduleName: string) {
    return require(`${vscode.env.appRoot}/node_modules.asar/${moduleName}`);
}

This seems to be a flaw/design decision by the extension to not provide it, and it is due to the fact that the author probably did not envision any other consumer (such as the framework), to be able to use the extension.

[dsseng]

Probably this issue should be transferred there, I see that it's caused by extension.

[akosyakov]

It is the same issue with keytar. We should add such packages as dependencies to @theia/plugin-ext-vscode, hook into require to intercept requests to such modules and implement own look up.

[dsseng]

@akosyakov keytar issue also causes the failure of Docker extension.

[akosyakov]

I've added keytar to discuss on next dev meeting. It requires additional dependencies which is not always necessary (some product can have own implementation of persisting secrets) but such dependencies rely on additional system tools to be installed.

[dsseng]

Might be related to #6407

[studentIvan]

Sorry for the spam, but this is the really useful extension. Hope someday theia can have it.

[vince-fugnitto]

Note that with #10736, we will benefit from having bracket colorizations directly from the application itself (like it is now done in vscode) which should be more performant than the plugins.

Additional Info:

• https://code.visualstudio.com/blogs/2021/09/29/bracket-pair-colorization

[vince-fugnitto]

Given that #10736 was merged, I'd be in favor of closing this issue.
The bracket pair colorizer should now be available by default in the framework.