Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: downgrade api version #12104

Merged
merged 1 commit into from
Jan 25, 2023
Merged

vscode: downgrade api version #12104

merged 1 commit into from
Jan 25, 2023

Conversation

vince-fugnitto
Copy link
Member

What it does

During today's dev meeting we discussed some concerns with bumping the API to a level that might cause issues due to stubbed tabs-related API support. The initial idea was to downgrade the API from v1.68.1 to v1.67.0 however that was incorrect as v1.67.0 actually introduces tabs support. The API is therefore downgraded to a version which should not cause issues.

How to test

Confirm CI passes.

Review checklist

Reminder for reviewers

@vince-fugnitto
vscode: downgrade api version
9f91e41 
The commit downgrades the API version for compatibility reasons.
The API is updated from `v1.68.1` to `v1.66.0`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jan 24, 2023
@vince-fugnitto
Copy link
Member Author

cc @JonasHelming @tsmaeder @colin-grant-work @msujew

Unfortunately it looks like v1.67.2 would also be problematic as a API level since it finalizes the tabs support. @msujew I understand this might cause issues with what you expressed in the meeting regarding inlay-hints.

What are your suggestions?

@msujew
Copy link
Member

msujew commented Jan 24, 2023

@vince-fugnitto I just thought it would be a quick-win to get [email protected] compliance using vscode version 1.67.0. But since we will upgrade our supported version with the tab API implementation soon anyway, I'm fine with 1.66.2 as well.

@JonasHelming JonasHelming mentioned this pull request Jan 25, 2023
Closed
@JonasHelming
Copy link
Contributor

@vince-fugnitto : Thank you for catching this. We are actually also depending on 1.67 for our use cases. However, for the release tomorrow, we should go to 1.66 as you propose. We will back port the fix of the tab API to the community release once it is available to fix this issue. I propose to merge this and do the further discussion here: #12105

msujew
msujew approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

By the way, I won't perform a localization downgrade since everything we are using from the 1.68.1 version of nls.metadata.json is also available in language packs with version 1.66.2.

@tsmaeder
Copy link
Contributor

Merging this one so we can proceed with build tomorrow.

@tsmaeder tsmaeder merged commit f87904a into master Jan 25, 2023
@github-actions github-actions bot added this to the 1.34.0 milestone Jan 25, 2023
@paul-marechal paul-marechal deleted the v1.34.0-api branch January 25, 2023 23:03
@Giangpro89

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

@JonasHelming JonasHelming Awaiting requested review from JonasHelming

@tsmaeder tsmaeder Awaiting requested review from tsmaeder

@colin-grant-work colin-grant-work Awaiting requested review from colin-grant-work

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vince-fugnitto @msujew @JonasHelming @tsmaeder @Giangpro89