Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: bump default api to 1.72.2 #12359

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

rschnekenbu
Copy link
Contributor

What it does

This pull-request updates the default vscode api from 1.70.2 to 1.72.2. With #12024 being fixed, the API compatibility can be raised.

Contributed on behalf of STMicroelectronics

How to test

N/A

Review checklist

Reminder for reviewers

@rschnekenbu rschnekenbu force-pushed the rs/bump-api-1.72.2 branch 2 times, most recently from 09c18eb to 0919f16 Compare March 29, 2023 13:15
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 29, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu
Copy link
Contributor Author

@vince-fugnitto, thanks a lot for the review! Is it possibe to merge this one?

@tsmaeder tsmaeder merged commit 3a2e796 into eclipse-theia:master Mar 30, 2023
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants