-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playwright: Update to latest versions and add new page objects #12384
playwright: Update to latest versions and add new page objects #12384
Conversation
Hi @planger, as you already had an initial look on my changes, could you perhaps suggest additional reviewers for this PR? Thank you! |
@vince-fugnitto Would you maybe have time to look into this change? I've already reviewed it internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, I confirmed they pass locally and during CI 👍
I'm not sure if @marcdumais-work would like to take a look as well but given it works it is likely not necessary. We can keep an eye out if things get flaky.
bfecfc9
to
a2c6f06
Compare
- Update `playwright` to the latest version - Update test configuration to adapt to latest version - Remove obsolete multiple config files and scripts - Add page objects for OutputView, OutputChannel, Toolbar, MonacoEditor - Extend tests by testing the new page objects - Extend ExplorerView tests with compact folders - Extend QuickCommand tests - Update GETTING_STARTED.md and DEVELOPING.md - Update build script to use ensure clean and lint are called - Ensure all necessary playwright dependencies are installed on initial build Signed-off-by: Nina Doschek <[email protected]>
a2c6f06
to
45dc854
Compare
@vince-fugnitto Thanks for the review! Let's merge this PR then and observe the stability. I'll rebase #12381 where Marc is added as a reviewer on top to make sure both changes work in combination. |
I was hoping to get #12320 in first due to issues with the "out-of-date" CI check but it's fine. |
Oh I see... sorry about that! I saw that Nina rebased and all checks passed. So I thought I'd save the build cycle and rebase mine (as it is the smaller change anyway) :-) |
What it does
playwright
to the latest versionSigned-off-by: Nina Doschek [email protected]
How to test
yarn test:playwright
from root directoryReview checklist
Reminder for reviewers