From 681fc11fce2f92861ce92506227ec15797b936ab Mon Sep 17 00:00:00 2001 From: Erez Odier <2045191+erezmus@users.noreply.github.com> Date: Wed, 19 Apr 2023 14:11:35 +0100 Subject: [PATCH 1/2] add catch method to handle promise rejection when exception thrown from the op callback --- packages/git/src/node/git-repository-manager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/git/src/node/git-repository-manager.ts b/packages/git/src/node/git-repository-manager.ts index a2668d0187b67..487ca077720eb 100644 --- a/packages/git/src/node/git-repository-manager.ts +++ b/packages/git/src/node/git-repository-manager.ts @@ -30,7 +30,7 @@ export class GitRepositoryManager { run(repository: Repository, op: () => Promise): Promise { const result = op(); - result.then(() => this.sync(repository)); + result.then(() => this.sync(repository)).catch(e => console.log(e)); return result; } From 3f14bceeb47fac60a232e044f7004d43a426315f Mon Sep 17 00:00:00 2001 From: Erez Odier <2045191+erezmus@users.noreply.github.com> Date: Wed, 30 Aug 2023 11:22:54 +0100 Subject: [PATCH 2/2] only catch sync errors --- packages/git/src/node/git-repository-manager.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/git/src/node/git-repository-manager.ts b/packages/git/src/node/git-repository-manager.ts index 3642d62492ae7..8f0b1af4c1a06 100644 --- a/packages/git/src/node/git-repository-manager.ts +++ b/packages/git/src/node/git-repository-manager.ts @@ -30,7 +30,8 @@ export class GitRepositoryManager { run(repository: Repository, op: () => Promise): Promise { const result = op(); - result.then(() => this.sync(repository)).catch(e => console.log(e)); + result.then(() => this.sync(repository).catch(e => console.log(e))); + return result; }