Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: bump to 23.2.4 #12464

Merged
merged 2 commits into from
Apr 27, 2023
Merged

electron: bump to 23.2.4 #12464

merged 2 commits into from
Apr 27, 2023

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes: #12461.

The pull-request bumps our version of electron to 23.2.4 which includes a backport fix for native menus.

How to test

  1. start the example electron application
  2. confirm that window.titleBarStyle is set to native
  3. resize the window - confirm that the submenus in the main-menu are working properly
  4. maximize the window with window controls - confirm that the submenus in the main-menu are working properly

Additional Information

Review checklist

Reminder for reviewers

The commit bumps our version of `electron` to `23.2.4` which includes a
backport fix for native menus.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added electron issues related to the electron target OS/Linux issues related to the Linux OS labels Apr 26, 2023
@vince-fugnitto vince-fugnitto self-assigned this Apr 26, 2023
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vince!

  • I can't reproduce the problem with the top menu
  • I confirmed that Electron's FFmpeg library is ok wr to proprietary codecs (our "replacement scheme" still works)

@marcdumais-work
Copy link
Contributor

@vince-fugnitto this is a relatively minor Electron upgrade, the minimal we could do to fix the annoying issue with the menus.Since we had no answer yet to your IP ticket question, I propose we go ahead and merge this for the release. WDYT?

@vince-fugnitto vince-fugnitto added this to the 1.37.0 milestone Apr 27, 2023
@vince-fugnitto vince-fugnitto merged commit a1be6ec into master Apr 27, 2023
@vince-fugnitto vince-fugnitto deleted the vf/electron-23.2.4 branch April 27, 2023 16:28
jonah-iden pushed a commit to jonah-iden/theia that referenced this pull request May 2, 2023
The commit bumps our version of `electron` to `23.2.4` which includes a backport fix for native menus on Linux.

Signed-off-by: vince-fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target OS/Linux issues related to the Linux OS
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

electron: native submenus do not appear reliably after resizing
2 participants