-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron: bump to 23.2.4
#12464
Merged
Merged
electron: bump to 23.2.4
#12464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit bumps our version of `electron` to `23.2.4` which includes a backport fix for native menus. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
electron
issues related to the electron target
OS/Linux
issues related to the Linux OS
labels
Apr 26, 2023
marcdumais-work
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Vince!
- I can't reproduce the problem with the top menu
- I confirmed that Electron's FFmpeg library is ok wr to proprietary codecs (our "replacement scheme" still works)
@vince-fugnitto this is a relatively minor Electron upgrade, the minimal we could do to fix the annoying issue with the menus.Since we had no answer yet to your IP ticket question, I propose we go ahead and merge this for the release. WDYT? |
jonah-iden
pushed a commit
to jonah-iden/theia
that referenced
this pull request
May 2, 2023
The commit bumps our version of `electron` to `23.2.4` which includes a backport fix for native menus on Linux. Signed-off-by: vince-fugnitto <[email protected]>
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #12461.
The pull-request bumps our version of
electron
to23.2.4
which includes a backport fix for native menus.How to test
window.titleBarStyle
is set tonative
Additional Information
[email protected]
(https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/7913)Review checklist
Reminder for reviewers