[vscode] Stub for proposed API: EditSessionIdentityProvider #12508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EditSessionIdentityProvider is a new proposed API. As of 1.72.2 it's only used in built-in git (vscode.git). This commit adds a stub implementation, sufficient to use vscode.git 1.72.2 and hopefully later versions, if we need it to. The eventual goal is to implement this API with a working implementation. Fixes eclipse-theia#12437 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added
vscode
marcdumais-work
force-pushed
the
new-proposed-apis-1.72.2-editSessionIdentityProvider
branch
from
6e4b850
to
d8a40ae
Compare
Co-authored-by: Vincent Fugnitto <[email protected]>
marcdumais-work
deleted the
new-proposed-apis-1.72.2-editSessionIdentityProvider
branch
tsmaeder
pushed a commit
to tsmaeder/theia
that referenced
this pull request
May 23, 2023
…theia#12508) * [vscode] Stub for proposed API: EditSessionIdentityProvider EditSessionIdentityProvider is a new proposed API. As of 1.72.2 it's only used in built-in git (vscode.git). This commit adds a stub implementation, sufficient to use vscode.git 1.72.2 and hopefully later versions, if we need it to. The eventual goal is to implement this API with a working implementation. Fixes eclipse-theia#12437 Signed-off-by: Marc Dumais <[email protected]> * Update packages/plugin-ext/src/plugin/workspace.ts Co-authored-by: Vincent Fugnitto <[email protected]> --------- Signed-off-by: Marc Dumais <[email protected]> Co-authored-by: Vincent Fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
EditSessionIdentityProvider is a new proposed API. As of 1.72.2 it's only used
in built-in git (vscode.git).
This commit adds a stub implementation, sufficient to use vscode.git 1.72.2 and
hopefully later versions, if we need it to. The eventual goal is to implement this
API with a working implementation.
Temporary test commit:To make it easier to test the stub implementation, a temporary commit as addedto the PR, to be removed before merging.
Change of plans: replacing @theia/git will definately interfere with some of our tests.
Instead here's the git diff of the commit, that can guide a reviewer how to modify locally
the example app, so it uses
[email protected]instead of@theia/git. This will beuseful to test locally this PR: (unzip locally - contains a single text file:
git-diff.txt)git-diff.zip
Fixes #12437
How to test
Do the changes suggested above so that the example app uses vscode built-in git instead of
@theia/git. Unzip the file below to an empty "plugins" folder at the root of the theia repo (a few
built-ins v1.72.2, not published yet). You may remove the markdown extension for now and keep
the two git extensions :
builtins-extensions-for-tests.zip
Do not run
yarn download:pluginsafter adding the vscode git extensions v1.72.2,since the command might install another version along, which might interfere with
the tests.
Review checklist
Reminder for reviewers