Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-editors: better styling and visible decorations #12598

Merged

Conversation

vladarama
Copy link
Contributor

What it does

This PR fixes #10821 by changing the styling of the open-editors view to align more closely with the styling of the explorer itself. These changes include making the decorations always visible even when the view becomes too small and adding an ellipsis overflow to the filename and their paths.

Demo:
open-editors styling

How to test

  • Start Theia application -> Go to Explorer View -> Make the Open Editors visible
  • Open or create new files, make some changes under source control
  • Resize the Open Editors view and observe the better styling

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer ui/ux issues related to user interface / user experience labels Jun 8, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I confirmed that the resizing behavior is correct, and there are no visible regressions from what I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

open-editors: better styling, and decorations should take precedence
2 participants