-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for windows execute command in terminal #12620
Merged
msujew
merged 4 commits into
eclipse-theia:master
from
jonah-iden:jiden/execute-command-in-terminal-fix
Jun 23, 2023
Merged
fix for windows execute command in terminal #12620
msujew
merged 4 commits into
eclipse-theia:master
from
jonah-iden:jiden/execute-command-in-terminal-fix
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <[email protected]>
msujew
added
terminal
issues related to the terminal
OS/Windows
issues related to the Windows OS
labels
Jun 14, 2023
msujew
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good, though I would like to see a minor refactoring regarding the use of EOL tokens, see below.
Signed-off-by: Jonah Iden <[email protected]>
msujew
reviewed
Jun 14, 2023
Signed-off-by: Jonah Iden <[email protected]>
msujew
reviewed
Jun 14, 2023
Signed-off-by: Jonah Iden <[email protected]>
msujew
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 👍
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes an issue that on windows commands where only pasted in the terminal and needed the user to press Enter again instead of being exeuted directly like in other Operating Systems
How to test
I tested it with the codeLLDB extension:
Review checklist
Reminder for reviewers