Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for windows execute command in terminal #12620

Merged
merged 4 commits into from
Jun 23, 2023
Merged

fix for windows execute command in terminal #12620

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12e249f
fix for windows execute command in terminal
jonah-iden Jun 14, 2023
b2d83d5
refactor: use OS.EOL instead of isWindows ? '\r\n' : '\n'
jonah-iden Jun 14, 2023
593d4b3
fixed wrong imports
jonah-iden Jun 14, 2023
0f2d0f3
overwritten new EOL property in preloader
jonah-iden Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/terminal/src/browser/terminal-widget-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
}

async executeCommand(commandOptions: CommandLineOptions): Promise<void> {
this.sendText(this.shellCommandBuilder.buildCommand(await this.processInfo, commandOptions) + '\n');
this.sendText(this.shellCommandBuilder.buildCommand(await this.processInfo, commandOptions) + (OS.backend.isWindows ? '\r\n' : '\n'));
msujew marked this conversation as resolved.
Show resolved Hide resolved
}

scrollLineUp(): void {
Expand Down