Fix for #12605: Edits made to watch expressions are not immediately shown when there is no debug session #12627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hether or not there is a debug session active so the updated expression can always be shown in UI. Fixes issue eclipse-theia#12605 Signed-off-by: Sophia Li <[email protected]>
robenthehood1
approved these changes
Jun 18, 2023
msujew
reviewed
Jun 26, 2023
There was a problem hiding this comment.
Hey @sophiali23 thank you for your first contribution!
Unfortunately, the changes don't seem to fix the issue at hand, see the following:
2023-06-27.00-00-53.mp4
Hi @msujew, this is a separate issue. The fix I implemented is in the watch panel: 2023-07-19_10h12_57.mp4 |
msujew
approved these changes
Aug 4, 2023
vince-fugnitto
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #12605. When no debug session is active and user edits a watch expression, the updated expression is not shown until Debug view is reopened or user clicks on the expression.
In the current code, the watch expression change event is not fired when there is no debug session, so I updated the logic to trigger it regardless of whether or not there is a debug session.
How to test
Review checklist
Reminder for reviewers