dialog: adding maxWidth to SingleTextInputDialog
#12642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds a maxWidth attribute to
SingleTextInputDialogs
in order to fix a styling issue that would occur when the input validation error message would get too long. This would cause the dialog to extend indefinitely. This fix adds a max-width of 400 px to the dialogs to make their styling more user-friendly. The modified dialogs include:New File
,New Folder
,Rename
andEditKeybinding
dialogs.Before:
After:
How to test
max-width: 400px
css styleEasy errors to test include: creating a file/folder with no name or a duplicate name,
renaming a file to the same name, creating empty key bindings ...
Should be merged after #12585
Review checklist
Reminder for reviewers