-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the file/newFile menu including menu entries #12819
Added the file/newFile menu including menu entries #12819
Conversation
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode displays things a bit differently:
Looking at the registered command, it seems they are using the shortTitle
of the command as the label of the quick pick item:
{
"title": "%python.command.python.createNewFile.title%", <-- "New Python File"
"shortTitle": "%python.menu.createNewFile.title%", <-- "Python File"
"category": "Python",
"command": "python.createNewFile"
},
Also, the item seemed to be grouped by a group
attribute of the registered menu entry. See here.
I think we should align to their design, which is a bit more focused on the actual file types than on the names of the commands.
On another note, I believe that the playwright tests need to be changed a bit.
yup have seen the playwright tests. |
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
it seems like there is currently no support in theia for both the |
@jonah-iden Can you create an issue for that and add the link to the |
Signed-off-by: Jonah Iden <[email protected]>
here is the issue #12824 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, with #12824 in mind, this looks good to me 👍
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ref: eclipse-theia/theia#12819 Signed-off-by: Akos Kitta <[email protected]>
Ref: eclipse-theia/theia#12819 Signed-off-by: Akos Kitta <[email protected]>
What it does
Fixes #12755
this adds the new file/newFile independent submenu which is used by extensions to contribute creation of new files with specific types.
The Menu is then used by the new File->New File... menu entry
Buttons to change keybindngs for the contributed new file commands are currently missing.
Out of some reason i couldn't find the commands in the keybindings
How to test
Best to test is probably with the Python extension
File
->New File...
New Python File
and see a new untitled .py file is createdReview checklist
Reminder for reviewers