Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new untitled file when double clicking on the main area or tabbar #12867

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

KR155E
Copy link
Contributor

@KR155E KR155E commented Aug 28, 2023

What it does

Fixes #8916

How to test

Double click on the empty area of the main dock panel when no widgets are opened or on the empty area of a tabbar. It should open a new untitled text file.

Review checklist

Reminder for reviewers

@KR155E
Copy link
Contributor Author

KR155E commented Sep 7, 2023

An additional note: when the main editor window is in split mode and there's more than one tabbar, then the untitled document is always added to the last active tabbar, even if you double click on the empty space of another, non-active tabbar.

IMHO it's a separate feature requirement to make the clicked-on tabbar active on the first click, unrelated to this feature.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KR155E, thank you for your first contribution :)

Looking pretty good. I just have a minor comment regarding the event naming, see below.

packages/core/src/browser/shell/application-shell.ts Outdated Show resolved Hide resolved
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me, thanks 👍

@msujew msujew merged commit a4d864b into eclipse-theia:master Sep 19, 2023
12 checks passed
@vince-fugnitto vince-fugnitto added the editor issues related to the editor label Sep 28, 2023
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
kittaakos pushed a commit to arduino/arduino-ide that referenced this pull request Oct 13, 2023
 - update translation VSIXs to `1.81.0`
 - revert eclipse-theia/theia#12867

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create new file when double click on the main-area or title bar
3 participants