Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search.quickOpen.includeHistory preference #12913

Merged

Conversation

KR155E
Copy link
Contributor

@KR155E KR155E commented Sep 16, 2023

What it does

This adds the search.quickOpen.includeHistory preference, allowing to define whether recently opened files should be shown in a separate section at the top of the file search quick open dialog, or not.

How to test

Toggle the preference on and off and check if it does what it should.

Review checklist

Reminder for reviewers

@msujew msujew added preferences issues related to preferences file search issues related to the file search labels Sep 25, 2023
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏼 The preference is properly localized
and works as expected. Thanks!

@tortmayr tortmayr merged commit 30d166e into eclipse-theia:master Oct 18, 2023
13 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.43.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file search issues related to the file search preferences issues related to preferences
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants