Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-s does not work for Webview Editor #12979

Closed
tsmaeder opened this issue Oct 8, 2023 · 1 comment
Closed

ctrl-s does not work for Webview Editor #12979

tsmaeder opened this issue Oct 8, 2023 · 1 comment
Labels
custom-editor issues related to custom-editor functionality webviews issues related to webviews

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Oct 8, 2023

Bug Description:

Steps to Reproduce:

When I edit a file with the draw.io editor (https://open-vsx.org/extension/hediet/vscode-drawio) ctrl-s has no effect

  1. Install the draw.io extension
  2. Create a file foo.drawio and open it
  3. Add a square figure
  4. Observe: the editor tab shows the "unsaved" circle
  5. type ctrl-s
  6. Observe: the editor tab still shows the "unsaved" circle

My expectation is for ctrl-s to save the editor. It works for text editors.

Additional Information

  • Operating System: Windows
  • Theia Version: 1.42.0 master
@tsmaeder tsmaeder changed the title <kbd>ctrl-s</kbd> does no work for Webview Editor ctrl-s does no work for Webview Editor Oct 8, 2023
@tsmaeder tsmaeder added the webviews issues related to webviews label Oct 8, 2023
@tsmaeder tsmaeder changed the title ctrl-s does no work for Webview Editor ctrl-s does not work for Webview Editor Oct 8, 2023
@msujew msujew added the custom-editor issues related to custom-editor functionality label May 5, 2024
@msujew
Copy link
Member

msujew commented May 5, 2024

I believe this is a duplicate of #9230. Our implementation of $trySaveDocument uses the EditorManager which doesn't seem to return the custom editor widget when you use getByUri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-editor issues related to custom-editor functionality webviews issues related to webviews
Projects
None yet
Development

No branches or pull requests

2 participants