Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language quick pick responsiveness #12992

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Oct 11, 2023

What it does

Closes #12991

Improves the responsiveness of the quick pick that appears when executing the Configure Display Language command:

  1. Correctly hides the quick pick when the current default language is selected (fix for Click on the current language before switching languages, switching languages will not take effect #12991)
  2. Shows a notification that the language pack is currently being downloaded/installed.

How to test

  1. Run the Configure Display Languages command.
  2. Before the languages are fetched from open-vsx, press enter to select the default language.
  3. The quick input should close as expected.

  1. Install a language package from open-vsx via the Configure Display Language command.
  2. During the plugin deployment, a notification appears in the application shell.
  3. Once the plugin is installed, the notification disappears.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Oct 11, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • confirmed that the default language correctly dismisses or hides the quick-input
  • confirmed that a progress notification is shown when a user attempts to download a language-pack
  • confirmed that the downloaded language-pack is correctly applied

@msujew msujew merged commit ff1ee2b into master Oct 12, 2023
13 checks passed
@msujew msujew deleted the msujew/improve-language-quick-pick branch October 12, 2023 10:36
@github-actions github-actions bot added this to the 1.43.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Click on the current language before switching languages, switching languages will not take effect
2 participants