Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12977
Fixes two localization based issues, see the first two commits for more info. The issue came from the fact that we now import a bit more code during our preload script and accidentally imported code that was supposed to be translated during its import time - effectively removing the ability to translate those files.
The same thing happened for monaco, where we import code from
@theia/monaco-editor-core
before being able to localize the monaco texts. This code has been moved to the correct package.How to test
Review checklist
Reminder for reviewers