Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly localize debug schema attributes #13017

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Oct 21, 2023

What it does

Closes #13004

Changes the behavior of the debug contributions so that the configurations are filled on the frontend instead of the backend. That allows access to the user locale to translate any description values.

Also eliminates a lot of dead/duplicated code in vscode-debug-adapter-contribution. The file appears to be unused and I don't expect any adopters to make use of the file.

How to test

  1. Install a language pack and switch to the new language
  2. Hover over the "builtin" attributes of the debug launch configs, such as type or name.
  3. They should be correctly localized to the current language.

Review checklist

Reminder for reviewers

@msujew msujew added debug issues that related to debug functionality localization issues related to localization/internalization/nls labels Oct 21, 2023
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msujew! Works fine and code looks good to me! Also thanks for the cleanup of the dead code.

@msujew msujew merged commit c057a5b into master Nov 22, 2023
12 of 13 checks passed
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 22, 2023
@msujew msujew deleted the msujew/localize-debug-contributions branch November 22, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Language pack localizations are not applied for launch config attributes
2 participants