fix(task): Align task group validation with VS Code #13075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In VS Code, the following is considered correct in a
tasks.json
:In Theia, however, this is considered an error as the enumeration in the JSON Schema restricts valid values to
isDefault: true
. This also prevents such tasks to be listed correctly when e.g. executing the command "Run Build Task".Contributed on behalf of STMicroelectronics.
Fixes #12917
How to test
tasks.json
with the following content:Follow-ups
There is another difference to the behavior of VS Code:
If there is only one task in the group, it'll be considered the default task and executed automatically. In Theia, the user is still prompted which task to execute even though there is just one. Not sure if we want to change that though.
Review checklist
Reminder for reviewers