-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common uuid generator everywhere #13255
Conversation
36aead1
to
8ed78e6
Compare
@msujew we still seem to require the uuid types package in some package.json files: |
In #13265 I am currently using uuid v5 to generate a hash that is an uuid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jfaltermeier I would recommend the reverse; Please merge your PR first and then I'll rebase :) |
@msujew Thanks, my PR is merged now |
@msujew I think this could be merged now |
c2082e4
to
a1cb124
Compare
a1cb124
to
7313a81
Compare
What it does
Since merging #12935, we now have a native way of generating UUIDs instead of relying on the
uuid
package directly. With #13082, this generator has been used a lot in@theia/core
. This change aligns the whole repo with this decision and removes all usage of theuuid
package in Theia.How to test
CI is green, manual smoke test is successful. Nothing should have changed in the behavior of the app.
Review checklist
Reminder for reviewers