-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump API version to 1.86.2 #13429
Merged
Merged
Bump API version to 1.86.2 #13429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschnekenbu
force-pushed
the
issues/13357
branch
from
February 28, 2024 15:59
105e703
to
56db6e6
Compare
The relevante VS Code version seems to be 1.86.2 why not put the API version at that number? https://eclipse-theia.github.io/vscode-theia-comparator/status.html |
Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
force-pushed
the
issues/13357
branch
from
February 29, 2024 10:13
56db6e6
to
3ec8f69
Compare
True! I updated api to 1.86.2 and rebased on master. |
tsmaeder
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!
Thanks @tsmaeder! |
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Increase compatibility version to 1.86.2 as implementation tasks from task #13356 are closed.
Fixes #13357
Contributed on behalf of STMicroelectronics
How to test
Make sure the system starts and built-ins work as expected as described in https://github.com/eclipse-theia/vscode-builtin-extensions/wiki/Produce-and-Publish-the-set-of-vscode-built-in-extensions#local-testing
Review checklist
Reminder for reviewers