Only initialize notebook cell editor when in viewport #13476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This implements parts of #13015
This optimizes the notebook editor widget so that monaco editors for code cells are only created once they come into the viewport. This should make opening large notbooks quite a bit more performant.
How to test
Open a notebook. Everything should still look the same. You should be able to see in the dom tree that all except the editors in the view are only mock editors with the estimated height of the content
Follow-ups
Review checklist
Reminder for reviewers