Notebook Outline-View and Breadcrumbs. #13562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ jupyter show Table of contents menu item working Signed-off-by: Jonah Iden <[email protected]>
jonah-iden
changed the title
msujew
reviewed
Apr 3, 2024
There was a problem hiding this comment.
There is a significant difference between the generated outline in vscode and Theia. Theia shows all cells (both markdown and code) in a flat list. In vscode, only markdown cells are shown, but in a hierarchical tree (depending on the level of heading):
Also, the label for those outline nodes isn't just the raw text, but the markdown rendered to plain text. Elements like **Hello** or `Hello` just become Hello.
packages/notebook/src/browser/contributions/notebook-actions-contribution.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/contributions/notebook-label-provider-contribution.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/contributions/notebook-ouline-contribution.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/contributions/notebook-ouline-contribution.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
|
As said in the followups markdown based hirachy and only showing markdown cells in outline is coming with a later PR |
msujew
reviewed
Apr 4, 2024
packages/notebook/src/browser/contributions/notebook-label-provider-contribution.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <[email protected]>
msujew
approved these changes
Apr 4, 2024
packages/notebook/src/browser/contributions/notebook-label-provider-contribution.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sujew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
this adds support for the outline view and breadcrumbs for the notebook editor.
Also makes the jupyter
Show Table of contentsmenu item working in the main notebook toolbar since its only opening the outline view.How to test
Create or open a notebook and see the breadcrumbs showing all cells.
Trust the workspace and click
Show Table of contents (Outline View)to reveal the outline view.Changing selection in editor or outline view should reflect respectivley
Follow-ups
There is currently no markdown based hirachy yet. That needs to be implemented later. Same as only showing code cells in the breadcrumbs and not in the outline view
Review checklist
Reminder for reviewers