Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Open With..." command UX #13573

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 8, 2024

What it does

Updates our UX for the "Open With..." menu entry to align with vscode

Previously:

image

After:

image

How to test

Notebook editors should work as expected with this:

  1. Add a notebook file (.ipynb) to your workspace
  2. Run the "Open With..." command via the context menu for that file
  3. It should show the text editor and Jupyter notebook options

Custom editors should still work as expected with this:

  1. Install the Hex Editor extension
  2. Run the "Open With..." command via the context menu for any file
  3. It should show the text editor and Hex editor options (among others)

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Apr 8, 2024
@msujew msujew requested a review from jonah-iden April 8, 2024 10:37
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great and i like the implementation with the open-with-service

@msujew msujew merged commit 3c05963 into master Apr 8, 2024
14 checks passed
@msujew msujew deleted the msujew/notebook-editor-label branch April 8, 2024 14:22
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 8, 2024
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this pull request Jun 21, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The
old "Open With" implementation in Theia was changed in favor of this
new service, but it broke current behaviour.

eclipse-theia/theia#13573

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this pull request Jun 21, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The
old "Open With" implementation in Theia was changed in favor of this
new service, but it broke current behaviour.

eclipse-theia/theia#13573

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this pull request Jun 21, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The
old "Open With" implementation in Theia was changed in favor of this
new service, but it broke current behaviour.

eclipse-theia/theia#13573

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to eclipse-cdt-cloud/theia-trace-extension that referenced this pull request Jun 28, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The
old "Open With" implementation in Theia was changed in favor of this
new service, but it broke current behaviour.

eclipse-theia/theia#13573

Signed-off-by: Bernd Hufmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants