-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Open With..." command UX #13573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonah-iden
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great and i like the implementation with the open-with-service
bhufmann
added a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 21, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The old "Open With" implementation in Theia was changed in favor of this new service, but it broke current behaviour. eclipse-theia/theia#13573 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 21, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The old "Open With" implementation in Theia was changed in favor of this new service, but it broke current behaviour. eclipse-theia/theia#13573 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 21, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The old "Open With" implementation in Theia was changed in favor of this new service, but it broke current behaviour. eclipse-theia/theia#13573 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Jun 28, 2024
Fix "Open With -> Trace Viewer" by using the new OpenWithService. The old "Open With" implementation in Theia was changed in favor of this new service, but it broke current behaviour. eclipse-theia/theia#13573 Signed-off-by: Bernd Hufmann <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Updates our UX for the "Open With..." menu entry to align with vscode
Previously:
After:
How to test
Notebook editors should work as expected with this:
.ipynb
) to your workspaceCustom editors should still work as expected with this:
Hex Editor
extensionReview checklist
Reminder for reviewers