Fix webview communication for Safari #13587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes outgoing messages from webviews being forwarded correctly to theia in safari.
while comparing a ProxyWindow with a Window object works in Firefox and Chrome In Safari they are never equal. Therefore this is now comparing the origin which since webviews are unique should be ok
How to test
Best way is probably through notebook outputs.
Start Theia in any browser you like, create a new notebook and add a simple
print('abc')
cell. Execute it (you need the jupyter and python extension for this). The output should appear.Follow-ups
Review checklist
Reminder for reviewers