Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webview communication for Safari #13587

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This fixes outgoing messages from webviews being forwarded correctly to theia in safari.
while comparing a ProxyWindow with a Window object works in Firefox and Chrome In Safari they are never equal. Therefore this is now comparing the origin which since webviews are unique should be ok

How to test

Best way is probably through notebook outputs.

Start Theia in any browser you like, create a new notebook and add a simple print('abc') cell. Execute it (you need the jupyter and python extension for this). The output should appear.

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden
Copy link
Contributor Author

@jbicker added you since your on mac and can therefore confirm this works correctly in safari

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me on FireFox/Chrome/Electron. I'll give a final approval after someone has tested this on Safari (MacOS).

@msujew msujew added webviews issues related to webviews browser/safari issues related to the safari browser notebook issues related to notebooks labels Apr 10, 2024
@msujew msujew changed the title fix webview communication for safari Fix webview communication for Safari Apr 10, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, approved 👍

@jonah-iden jonah-iden merged commit 106da53 into master Apr 17, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/fix-webview-communication-safari branch April 17, 2024 13:24
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser/safari issues related to the safari browser notebook issues related to notebooks webviews issues related to webviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants