Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook context selection #14179

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix notebook context selection #14179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/notebook/src/browser/notebook-editor-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export class NotebookEditorWidget extends ReactWidget implements Navigatable, Sa

protected render(): ReactNode {
if (this._model) {
return <div className='theia-notebook-main-container'>
return <div className='theia-notebook-main-container' tabIndex={-1}>
<div className='theia-notebook-overlay'>
<NotebookFindWidget
ref={this._findWidgetRef}
Expand Down
4 changes: 4 additions & 0 deletions packages/notebook/src/browser/style/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,10 @@
overflow: hidden;
}

.theia-notebook-main-container:focus {
outline: none;
}

.theia-notebook-main-container .theia-notebook-main-loading-indicator {
/* `progress-animation` is defined in `packages/core/src/browser/style/progress-bar.css` */
animation: progress-animation 1.8s 0s infinite cubic-bezier(0.645, 0.045, 0.355, 1);
Expand Down
Loading