Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Playwright test - notebook split cell #14450 #14457

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dhuebner
Copy link
Member

What it does

  • Removed flaky expectation that assumes a line element has state visible Intermittent Playwright test failures in theia-notebook-editor.test #14450
  • Added logging to see the line element state if the test should fail again
  • Updated Playwright to ^1.47.0 because earlier versions are not working with OS X Sequoia
  • Added allure-results to .gitignore . It is produced during Playwright tests run
  • Adjusted test workspace location detection, because in the latest Playwright plug-in the working directory is the workspace root. In the older version it was the playwright configuration file directory.

How to test

Tests are running automatically

Follow-ups

Further investigate failing flaky test using new logging data as it is not reproducible locally.

Review checklist

Reminder for reviewers

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Code changes look good and the Playwright upgrade is also more than welcome. Let's observe whether this already resolves the flakiness. At least it'll give us more insights.

Thanks again!

@dhuebner
Copy link
Member Author

@planger
Do you know what causes the (Apache-2.0) License problem in playwright package?

@planger
Copy link
Contributor

planger commented Nov 18, 2024

@dhuebner No unfortunately not, I'm afraid. Did they add some problematic dependency?

@tsmaeder
Copy link
Contributor

@dhuebner you can run yarn license:check:review in the Theia root dir after setting the DASH_LICENSES_PAT environment variable. This will automatically open an issue on the EF IP-Check gitlab. The PAT is described here: https://github.com/eclipse-dash/dash-licenses?tab=readme-ov-file#automatic-ip-team-review-requests

@dhuebner
Copy link
Member Author

@tsmaeder
Thank you a lot for your hints.
Review ticked created: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/17367

@dhuebner dhuebner merged commit 832287d into master Nov 22, 2024
11 checks passed
@dhuebner dhuebner deleted the dhuebner/playwright-flaky-14450 branch November 22, 2024 08:13
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants