Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tests using Java records #3258

Open
LorenzoBettini opened this issue Nov 26, 2024 · 1 comment · May be fixed by #3261
Open

Cleanup tests using Java records #3258

LorenzoBettini opened this issue Nov 26, 2024 · 1 comment · May be fixed by #3261

Comments

@LorenzoBettini
Copy link
Contributor

LorenzoBettini commented Nov 26, 2024

When Java 17 PR is merged, tests using Java records, based on assuming Java 21, should be updated NOT to check for Java 21 since records have been present since Java 17. Also remove dep on draw2d just for referring to a Java record: we can have a Java record as part of our testdata.

@LorenzoBettini
Copy link
Contributor Author

search for Assume.assumeTrue("Active only on Java 21 and later", JavaRuntimeVersion.isJava21OrLater());

@LorenzoBettini LorenzoBettini linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant