We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some functions returns Promise, some not. I don't see any system in this. E.g.:
Promise
interface LivelinessSubscriberOptions { callback?: (sample: Sample) => Promise<void>; } export declare class Liveliness { declare_subscriber(key_expr: IntoKeyExpr, options?: LivelinessSubscriberOptions): Subscriber;
but
export interface QueryableOptions { callback?: (query: Query) => void; } export declare class Session { declare_subscriber(key_expr: IntoKeyExpr, handler?: ((sample: Sample) => Promise<void>) | Handler): Promise<Subscriber>;
Also why for liveliness' Subscriber callback is in options, but for session's one - in parameter and there is no options (dummy at this moment)
callback
Need to go through ts API and align it. The zenoh-c and zenoh-cpp APIs can be used as a reference
The text was updated successfully, but these errors were encountered:
Charles-Schleich
No branches or pull requests
Some functions returns
Promise
, some not. I don't see any system in this.E.g.:
but
Also why for liveliness' Subscriber
callback
is in options, but for session's one - in parameter and there is no options (dummy at this moment)Need to go through ts API and align it. The zenoh-c and zenoh-cpp APIs can be used as a reference
The text was updated successfully, but these errors were encountered: