Improve ssl buffers handling #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
lorban
added
the
Sponsored
gregw
requested changes
Jun 14, 2022
There was a problem hiding this comment.
I don't like the "clear to force a release later" pattern. Instead just have clearly named methods that release if empty vs always releases:
releaseEmptyInputBuffers;releaseInputBuffersreleaseInputBuffersIfEmpty;clearAndReleaseInputBuffers
But ultimately, we should not need comments like "clearing so a later release will take effect". Instead we should just release immediately in those locations - the subsequent final releases are already null check protected.
jetty-io/src/main/java/org/eclipse/jetty/io/ArrayRetainableByteBufferPool.java
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Jun 15, 2022
jetty-io/src/main/java/org/eclipse/jetty/io/ArrayRetainableByteBufferPool.java
Show resolved
Hide resolved
jetty-server/src/main/config/modules/retainablebytebufferpool.mod
Outdated
Show resolved
Hide resolved
jetty-server/src/main/config/modules/retainablebytebufferpool.mod
Outdated
Show resolved
Hide resolved
jetty-server/src/main/config/modules/retainablebytebufferpool.mod
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
approved these changes
Jun 15, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #8161