Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support xml.format.joinContentLines setting with experimental formatter #1244

Closed
angelozerr opened this issue Jul 1, 2022 · 1 comment · Fixed by #1298
Closed

Support xml.format.joinContentLines setting with experimental formatter #1244

angelozerr opened this issue Jul 1, 2022 · 1 comment · Fixed by #1298
Assignees
@JessicaJHee
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone
0.22.0

Comments

@angelozerr
Copy link
Contributor

See https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatjoincontentlines
@angelozerr angelozerr added the formatting This issue or enhancement is related to formatting support label Jul 1, 2022
@datho7561
Copy link
Contributor

This is one of the more important settings to support at this point, IMO. The old formatter disabled this setting. However, in the experimental formatter, it behaves as though joinContentLines=true

@angelozerr angelozerr mentioned this issue Sep 21, 2022
Merged
@JessicaJHee JessicaJHee self-assigned this Sep 22, 2022
@JessicaJHee JessicaJHee mentioned this issue Sep 22, 2022
Merged
@datho7561 datho7561 added this to the 0.22.0 milestone Sep 23, 2022
@datho7561 datho7561 added the enhancement New feature or request label Sep 23, 2022
@JessicaJHee JessicaJHee mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaJHee JessicaJHee

Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Support joinContentLines settings with experimental formatter JessicaJHee/lemminx
3 participants
@angelozerr @datho7561 @JessicaJHee