Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module imports to intermediate layers when hoisting temporaries #297

Closed
awnawab opened this issue Apr 23, 2024 · 1 comment · Fixed by #321
Closed

Add module imports to intermediate layers when hoisting temporaries #297

awnawab opened this issue Apr 23, 2024 · 1 comment · Fixed by #321
Labels
enhancement New feature or request

Comments

@awnawab
Copy link
Contributor

awnawab commented Apr 23, 2024

If module imports are used to define temporary array sizes deep in a call-tree, these variables might be undefined in intermediate layers when the temporaries are hoisted up to the driver. This should be taken care of by the transformation, possibly by storing all array size related module imports in item.trafo_data, and subsequently appending these imports as necessary to subroutine.spec as we move up the call-tree.

@awnawab awnawab added the enhancement New feature or request label Apr 23, 2024
@reuterbal
Copy link
Collaborator

Will this be fixed by #321?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants