-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-3026] - Snapshot Testing Improvements #815
Conversation
3f0e85d
to
e9f4741
Compare
Looks like the first one linked did not run the snapshot tests at all, apparently because there was no version update, probably you had already re-introduced the correct versioning logic then? I found this older one (https://github.com/ecosia/ios-browser/actions/runs/11825657659) which seems like what you want, still a huge improvement from 1h to 18min 🎉 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked into the new script and the new configuration files and they look good 🙌
The performance improvement is huge 👏 🎉
Can't look into much else due to the change size, but from my side all good to go ✅
MOB-3026
Context
We want to introduce a series of improvements to reduce the CI time and improve test reliability.
Approach
runsOn
overrides the default device and executes a dedicated build (useful for iPad-specific tests for instance that will produce a dedicated UI)["all" "portrait"]
as part of the devices list for a certain test classHave a look at the decrease in timing https://github.com/ecosia/ios-browser/actions/runs/11826256998
Compared to an old successful snapshot run https://github.com/ecosia/ios-browser/actions/runs/11775291296
Other
Next Steps? Have a dedicated branch for storing Snapshots. Ticket incoming 🎟️ .
The change is too big because of the newer snapshots. To review the files feel free to check the newer script and the newer configuration.
🤖 Same reason for the PR Agent failing. 🤖
Before merging
Checklist