Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-3077] Add en-AU release notes #821

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

d4r1091
Copy link
Member

@d4r1091 d4r1091 commented Nov 28, 2024

MOB-3077

Context

We are adding a new language to the AppStore metadata, mainly for Marketing reasons.

Approach

Add the en-AU with the appropriate mapping.

Other

Take the occasion to rename the yml file, as wronly added with the :.

@d4r1091 d4r1091 requested a review from a team November 28, 2024 10:30
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Collaborator

@ecotopian ecotopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🇦🇺

Is it related that unit tests fail or are they flaky?

@d4r1091
Copy link
Member Author

d4r1091 commented Nov 29, 2024

@ecotopian it seems like there is some flakiness on the AnalyticsMenu ones - I will take a closer look if it happens again

@d4r1091 d4r1091 merged commit b885ce7 into main Dec 2, 2024
2 of 3 checks passed
@d4r1091 d4r1091 deleted the dc-mob-3077-support-en-au-automation branch December 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants