Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Playstation Logo #860

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Adding Playstation Logo #860

merged 5 commits into from
Oct 23, 2024

Conversation

kycilius
Copy link
Contributor

@kycilius kycilius commented Oct 21, 2024

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • You have read the contributing guidelines
  • The icon's size is under 1,024 Bytes
  • The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

Add Playstation Logo #857

@edent
Copy link
Owner

edent commented Oct 21, 2024

Nearly there.

  • Fix the formatting so it doesn't have spaces at the start of lines.
  • Name should just be "PlayStation" - no need for the word "logo".
  • Looking on the official site, I think the colour should be #0070d1

@kycilius
Copy link
Contributor Author

Thanks for the review @edent
I hope this will be perfect.

@kycilius
Copy link
Contributor Author

@edent is it good

@edent
Copy link
Owner

edent commented Oct 23, 2024

@kycilius Almost!

Yours starts like this:

<svg xmlns="http://www.w3.org/2000/svg"
  aria-label="PlayStation" role="img"
  viewBox="0 0 512 512">

Can you see how that's different from all the other images in the repo?

@edent edent merged commit f580c60 into edent:master Oct 23, 2024
1 check passed
@edent edent mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants