Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edgedb list branches as the branch analog to edgedb list databases #1275

Closed
raddevon opened this issue Apr 2, 2024 · 3 comments · Fixed by #1284
Closed

Add edgedb list branches as the branch analog to edgedb list databases #1275

raddevon opened this issue Apr 2, 2024 · 3 comments · Fixed by #1284
Assignees
Labels

Comments

@raddevon
Copy link
Contributor

raddevon commented Apr 2, 2024

list databases does seem to work on v5 instances, but people may not know to use it since we are re-training them that databases are out and branches are in. Looks to me like list branches could just be an alias for list databases except that I guess it should probably fail on pre-v5.

@1st1
Copy link
Member

1st1 commented Apr 2, 2024

I think we should instead deprecate list databases and print a recommendation to use branch list

@raddevon
Copy link
Contributor Author

raddevon commented Apr 2, 2024

Would we then make that command (edgedb branch list) work for users on versions prior to 5 to list their databases, or would that recommendation not apply to the users who would have wanted to use edgedb list databases to list databases on a pre-v5 database? Either of those seems like awkward DX to me, but maybe there's a third option I'm not considering…

@quinchs
Copy link
Contributor

quinchs commented Apr 3, 2024

If you run list databases on a 5.x server we can print a deprecation warning~ but I agree that pre-5.0 should not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants