Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PARKED] annotation export POC #1216

Closed
wants to merge 27 commits into from
Closed

[PARKED] annotation export POC #1216

wants to merge 27 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Oct 14, 2020

No description provided.

@panaC panaC self-assigned this Oct 14, 2020
@danielweck
Copy link
Member

Accessible colour picker: https://github.com/omgovich/react-colorful

@danielweck danielweck marked this pull request as draft November 20, 2020 15:25
@panaC panaC mentioned this pull request Sep 11, 2021
Closed
@panaC
Copy link
Member Author

panaC commented Aug 15, 2023

brainstorming in french

panaC and others added 23 commits September 12, 2023 13:57
@panaC
first
28665f0
@panaC
merge/rebase from develop
8105489
@panaC
up
861d17d
@panaC
annotation user interface
a297869 
Prepare connection to picker
@panaC
annotation button
0d8cb5f
@panaC
annotation on/off
466aaca
@panaC
up
6419b61
@panaC
add anotations list in readerMenu + goToLocator with hightlight focus…
4d4e357 
… if annotation not enable [skip ci]
@panaC
connect annotation picker [skip ci]
53f9bfe
@panaC
up
02d09e2 
- annotation picker html form :: need works!
- picker enabled in viewer mode not new annotation allowed
- click on one item in annotation list and annotation mode disabled open picker and goToLocator with selection highlight
@panaC
click
fb061f0
@panaC
dispatch name, comment in picker
4ce4be4
@panaC
fill anotationUI.focus event, refactor focus behaviour
e5222ea
@panaC
up
492b393
@panaC
picker
99d9253
@panaC
hash
a624dc7
@panaC
up
1efb329
@panaC
clone color obj
e2266f8
@panaC
redux persistence doesn't work on annotationUpdate
57e4e9c 
this is because ramda.equals doesn't deep equal obj inside aray

set manually instead
@panaC
lint
4c3d152
@panaC
close picker if deleted annotation in readerMenu
314266e
@panaC
fixes: update annotation model to get all LocatorExtended saved and r…
27847f6 
…emove name properties
@panaC
add: w3c annotation converter
8e7f97d
@panaC panaC force-pushed the panac/feature/annotation branch from e7126b8 to 084c42d Compare September 12, 2023 12:00
@gautierchomel gautierchomel mentioned this pull request Oct 29, 2023
Closed
@danielweck danielweck closed this Apr 12, 2024
@danielweck danielweck deleted the panac/feature/annotation branch April 25, 2024 09:53
@panaC panaC restored the panac/feature/annotation branch April 29, 2024 13:00
@panaC panaC reopened this Apr 29, 2024
@panaC
Copy link
Member Author

panaC commented Apr 29, 2024

WIP PR/branch
annotation exportation POC/TEST

@panaC panaC changed the title [WIP] annotation [WIP] annotation export POC Apr 29, 2024
@danielweck
Copy link
Member

Oh sorry @panaC this PR named "annotations" was 7 months old and full of merge conflicts so I assumed it was totally obsolete! (given that there is a working implementation already in the develop branch). So I closed the PR and deleted the branch as part of housekeeping (this repository had many obsolete source trees, including my own experiments). Apologies. Do you intend to resolve all the merge conflicts and continue to use this branch / PR?

@panaC
Copy link
Member Author

panaC commented Apr 30, 2024

Oh sorry @panaC this PR named "annotations" was 7 months old and full of merge conflicts so I assumed it was totally obsolete! (given that there is a working implementation already in the develop branch). So I closed the PR and deleted the branch as part of housekeeping (this repository had many obsolete source trees, including my own experiments). Apologies. Do you intend to resolve all the merge conflicts and continue to use this branch / PR?

No problems :) , I just keep it as a reference, the branch is no longer usable/mergeable anymore.

@danielweck danielweck changed the title [WIP] annotation export POC [PARKED] annotation export POC May 28, 2024
@panaC
Copy link
Member Author

panaC commented Jul 1, 2024

superseded by 079471f

@panaC panaC closed this Jul 1, 2024
@danielweck danielweck deleted the panac/feature/annotation branch November 13, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panaC panaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panaC @danielweck