Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech TTS voice selector #2513

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Speech TTS voice selector #2513

merged 15 commits into from
Dec 3, 2024

Conversation

panaC
Copy link
Member

@panaC panaC commented Aug 19, 2024

No description provided.

@panaC panaC self-assigned this Aug 19, 2024
@panaC panaC marked this pull request as draft August 19, 2024 13:57
@panaC panaC mentioned this pull request Aug 19, 2024
Closed
@panaC
Copy link
Member Author

panaC commented Aug 30, 2024

The tts voice is attached to the publication.
when first opening a publication, the tts voice is not set. The tts voice is updated only when opening the tts control panel not before. So the tts voice is not set on first reading until the user opens the control panel, the voice is in a undefined state.

when the tts voice has been updated in the control panel, the voice is attached and persisted to the publication.

default Voice :
image

default Voice accessible EPUB3 :
image

About the Localisation : the languages labels and regions labels in both combobox is translated with Intl.

TODO :

  • need to merge the readium-speech PR
  • update the npm package link to 'readium-speech' when pushed to NPM registry
  • need to improve the css margin of the ttsVoice component in control panel
  • need to discuss about the tts voice persistence across publication.

@panaC panaC marked this pull request as ready for review November 7, 2024 14:37
@panaC
Copy link
Member Author

panaC commented Nov 27, 2024

This PR is ready to review

@danielweck
Copy link
Member

nit-pick: see the GUI gap:

Screenshot 2024-11-27 at 15 26 10

@danielweck
Copy link
Member

I tested with Wasteland, the UX is a net improvement over Thorium v3.0.0 (I was able to easily select and test English, German, Italian, Greek, etc. languages).

@panaC
Copy link
Member Author

panaC commented Nov 27, 2024

@danielweck I will separate the src and build folders with git branches as I did on your recommendation on edrlab/pdf.js#master2 vs edrlab/pdf.js#build

@panaC
Copy link
Member Author

panaC commented Dec 3, 2024

I'm plan to merge this PR today, seems to be enough mature to be merged asap, we have just to keep updated the readium/speech repo.

panaC added 4 commits December 3, 2024 13:55
@panaC
Merge branch 'develop' into new_ttspeech
ffc4d9b
@panaC
add locales
815077d
@panaC
fix: readerDefaultConfig locally and across the app
6570a30 
disable ttsVoice global readerConfig persistence

I also create a fresh copy of annotation_defaultColor on
READER_DEFAULT_CONFIG_SET_REQUEST action
@panaC
fix previous commit readerDefaultConfigCopyWithoutTTSVoice var not used
602fe07 
for savePublisherSettings action
@panaC panaC merged commit 03c2e25 into develop Dec 3, 2024
7 checks passed
@panaC panaC deleted the new_ttspeech branch December 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panaC panaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panaC @danielweck @arthur-lemeur