-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DS-322): add remove command for remove TVM project #60
Conversation
8e9e58c
to
cc5b10f
Compare
06506ca
to
3006c06
Compare
This works, I just suggest be more clear about the difference between use the flag or not (for me isn't total clear, I had to test to be clear), |
065d30e
to
8e01807
Compare
Thank you @dcoa, i have been correcting the order of the arguments and adding more information about the functionality of this command, you can test it again? the idea is be the clearest as possible. |
8e01807
to
92709bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its working well!! I think the documentation is clear to begin to use this command.
I tried to remove a project env following the documentation, and I can't do it. On the other hand, I think it's better if we change the Remove a Project to Remove a Project Environment subtitle in the doc to be more explicit about what you will remove if you call this command, because when you use the flag, it is clear. If you don't want to change the subtitle, maybe you can add a short description specifying what will be removed if you don't use the flag. |
You're right @MaferMazu, the documentation has to be changed. |
e27fb43
e27fb43
to
0015f77
Compare
Thank you @MaferMazu, the PR comment and docs are updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✨ Thanks for updating the doc.
Description
This PR is to add a command to remove TVM projects.
Also solves #48
Jira
DS-322
How to test
tvm project init test v13.3.1
tvm project remove v13.3.1@test
ortvm project remove v13.3.1@test --prune