Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DS-291): create a project with a version that is not install #58

Merged
merged 3 commits into from
Oct 25, 2022
Merged

fix(DS-291): create a project with a version that is not install #58

merged 3 commits into from
Oct 25, 2022

Conversation

JuanDavidBuitrago
Copy link
Member

@JuanDavidBuitrago JuanDavidBuitrago commented Oct 21, 2022 •
edited
Loading

Description

This PR:

Testing instructions

  1. Install TVM with this branch
pip install git+https://github.com/eduNEXT/tvm.git@JDB/not_install_version_init
  1. Run init comman
tvm project init <project_name> <version_that_isn't_install>

@JuanDavidBuitrago JuanDavidBuitrago self-assigned this Oct 21, 2022
@JuanDavidBuitrago JuanDavidBuitrago linked an issue Oct 21, 2022 that may be closed by this pull request
[BUG] Cant create a project with a version that is not install #52
Closed
Henrrypg
Henrrypg previously approved these changes Oct 21, 2022
View reviewed changes
MaferMazu
MaferMazu reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@MaferMazu MaferMazu left a comment •
edited by JuanDavidBuitrago
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I think We need to change the doc.

What do you think?

.github/pull_request_template.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/m and removed size/s labels Oct 21, 2022
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/not_install_version_init branch from a8cd593 to 29745a8 Compare October 21, 2022 15:57
Henrrypg
Henrrypg previously approved these changes Oct 21, 2022
View reviewed changes
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/not_install_version_init branch from 29745a8 to 21498f6 Compare October 21, 2022 20:15
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/not_install_version_init branch from 21498f6 to baa1cc2 Compare October 21, 2022 20:30
MaferMazu
MaferMazu approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊 Looks good to me

@MaferMazu MaferMazu merged commit 8adc08a into main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Henrrypg Henrrypg Henrrypg approved these changes

@MaferMazu MaferMazu MaferMazu approved these changes

@Alec4r Alec4r Awaiting requested review from Alec4r

@dcoa dcoa Awaiting requested review from dcoa

@danielsgz danielsgz Awaiting requested review from danielsgz

Assignees

@JuanDavidBuitrago JuanDavidBuitrago

Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cant create a project with a version that is not install
3 participants
@JuanDavidBuitrago @MaferMazu @Henrrypg