Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatibility with newer moment versions? #61

Open
marwahaha opened this issue Jan 17, 2019 · 2 comments
Open

incompatibility with newer moment versions? #61

marwahaha opened this issue Jan 17, 2019 · 2 comments

Comments

@marwahaha
Copy link

  1. is this ticket still relevant? 2.19.1: can no longer combine moment, moment-timezone and moment-business-days moment/moment#4236
  2. if so, can it be fixed from the plugin side?
@mcdado
Copy link
Collaborator

mcdado commented Jan 17, 2019

Personally I don't use other plugins so I didn't run into this issue.
What is the "blessed" way of making sure a plugin module should behave? Should moment-business-day accept a moment object as parameter and modify it? Or should it consider it a peer dependency and expect to require() it?

@marwahaha
Copy link
Author

I'm not 100% sure. @ichernev may know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcdado @marwahaha