Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return which work day it is. #62

Open
Evilu opened this issue Jan 27, 2019 · 4 comments
Open

return which work day it is. #62

Evilu opened this issue Jan 27, 2019 · 4 comments

Comments

@Evilu
Copy link

Evilu commented Jan 27, 2019

I would be really happy if you'll add a function that returns which buisness day is entered.
it is crucial for Statistics.

For example 2019-01-10 will return the number 9.

@oleg-koval
Copy link
Contributor

@Evilu
nice idea, but can you please explain how 2019-01-10 should return 9? Why not 7? As 1st of January isn't a business day, you have 2,3,4,7,8,9,10

@mcdado
Copy link
Collaborator

mcdado commented Feb 11, 2019

As 1st of January isn't a business day

Well, it all depends on locale settings…

Regarding the feature, if on non-business day like 2019-01-10 (which is a Sunday, if Sundays are non business days in the locale setting, of course) should it count 1 up or one 1 down?

@mcdado
Copy link
Collaborator

mcdado commented Feb 11, 2019

1 down is basically saying the amount of business days before the date, 1 up is considering the day itself as an extra day… I might be wrong but the latter might be more consistent

@oleg-koval
Copy link
Contributor

Also, should it be like a total count of business days or per month?

f.e.:

January 10, 2019, is 9 days
What about June 10 2019, should it be counted from 1 of June or 1 of January?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants