Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnuzz/update to dbt 1 5 #81

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Dnuzz/update to dbt 1 5 #81

merged 9 commits into from
Mar 28, 2024

Conversation

dnuzz
Copy link
Contributor

@dnuzz dnuzz commented Jun 5, 2023

Description: Describe in a couple of sentences what this PR adds

JIRA: Link to JIRA ticket

Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@dnuzz dnuzz requested a review from a team as a code owner June 5, 2023 14:48
@HassanJaveed84
Copy link

I don't remember the version being used in warehouse transforms, but that also should be updated to match this.

@abdulrafey38
Copy link
Contributor

abdulrafey38 commented Jul 17, 2023

I don't remember the version being used in warehouse transforms, but that also should be updated to match this.

we are using 1.3 right now in warehouse
here is the PR for matching the version https://github.com/edx/warehouse-transforms/pull/4250

@dnuzz
Copy link
Contributor Author

dnuzz commented Jul 27, 2023

Ah I thought the version was pinned, but I found the DSL and you are correct it always goes to latest. I might suggest that we pin the version here to the current version before we go doing the upgrade. I could see things taking a while to properly upgrade and test. Might as well buy ourselves a little time?

@abdulrafey38
Copy link
Contributor

Ah I thought the version was pinned, but I found the DSL and you are correct it always goes to latest. I might suggest that we pin the version here to the current version before we go doing the upgrade. I could see things taking a while to properly upgrade and test. Might as well buy ourselves a little time?

@dnuzz so we need to pin 0.4.11 ==> here right? because after upgrade the latest version will be 0.5.0

@dnuzz
Copy link
Contributor Author

dnuzz commented Aug 2, 2023

@abdulrafey38 correct pin it there to that version. We can unpin later if we also want to upgrade that

@abdulrafey38
Copy link
Contributor

0.4.11

edx/jenkins-job-dsl#1662

@abdulrafey38 abdulrafey38 merged commit fcb796f into main Mar 28, 2024
@abdulrafey38 abdulrafey38 deleted the dnuzz/update_to_dbt_1_5 branch March 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants